Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 15, 2022

follow-up #15109 (comment)

this file is no longer used.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from thaJeztah July 15, 2022 19:20
@crazy-max crazy-max marked this pull request as draft July 15, 2022 19:22
@netlify
Copy link

netlify bot commented Jul 15, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e70adf
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62d1be059cd97a0009abfb5e
😎 Deploy Preview https://deploy-preview-15132--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@crazy-max crazy-max marked this pull request as ready for review July 15, 2022 19:23
@thaJeztah
Copy link
Member

Just to be sure; did we check if there's any redirects in this file that were not included in any of the replacements?

@crazy-max
Copy link
Member Author

I didn't go through all of them but afaik this file is not used for a long time and if a user had a 404 during this period he would have created an issue no?

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, that's fair

LGTM

@thaJeztah thaJeztah merged commit 8786d55 into docker:master Jul 25, 2022
@crazy-max crazy-max deleted the remove-redirects-csv branch July 25, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants