move s3 redirects to jekyll redirect_from #15133
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
move-s3-redirects
branch
from
5e52db5 to
820d9c4
Compare
| - /v1.4/ | ||
| - /v1.5/ | ||
| - /v1.6/ | ||
| - /v1.7/ | ||
| - /v1.8/ | ||
| - /v1.9/ | ||
| - /v1.10/ | ||
| - /v1.10/ |
There was a problem hiding this comment.
I'm not sure these would work; the current redirects match by prefix (so /v1.4/engine/reference/commandline/cli/ (e.g.) would redirect to /engine/reference/commandline/cli/ etc.
There was a problem hiding this comment.
Ohhh that's a very good point, didn't catch that we were using KeyPrefixEquals
There was a problem hiding this comment.
I guess we have to handle that with the lambda edge function I was working on.
There was a problem hiding this comment.
Yeah, we could add some of those I guess; then again, the current ones works, so perhaps no need to spend too much time on that for now
|
carry changes in #15151 using the lambda function instead. |
2 participants
follow-up #15109
This is in preparation for a follow-up PR to handle redirects directly in our Cloudfront distribution: crazy-max@d44d840
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com