Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 27, 2022

related #15223

Upgrading Font Awesome has broken our social icons:

image

Before we had:

image

With these changes:

image

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

Not linked but we might update the copyright footer and makes dynamic the current year 2021: https://github.com/docker/docker.github.io/blob/8b1c893b143c14957e63ec8d693150916792bd9d/_includes/footer.html#L87

@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dbc6423
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62e1823b0bc4e10008dd4219
😎 Deploy Preview https://deploy-preview-15234--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I completely missed those 😅

@thaJeztah thaJeztah merged commit c13b509 into docker:master Jul 27, 2022
@crazy-max crazy-max deleted the fix-icons branch July 27, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants