-
Notifications
You must be signed in to change notification settings - Fork 8.1k
DD4L: Replace download links with per-distro install instruction links #15259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD4L: Replace download links with per-distro install instruction links #15259
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for PR @p1-0tr. Can we add the download packages (as a button) to the Ubuntu, Fedora and Debian pages, so users don't have to navigate to the release notes to install. Also, I'm not sure about displaying the links to the pages as buttons. I think it would be better to do something like: 'Follow the links below to view the distro-specific installation instructions: We could still wrap it in a note to make it pop out from the text. |
8c8f3ba to
05f2a1d
Compare
desktop/install/debian.md
Outdated
| 1. Set up [Docker's package repository](../../engine/install/debian.md#set-up-the-repository). | ||
|
|
||
| 2. Download latest DEB package from the [release](../release-notes.md) page. | ||
| 2. Download latest DEB package: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @p1-0tr , that was a bad idea of mine - this doesn't look great. Let's just keep it as it was with the links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :) I made them direct download links, but inline
| This page contains information about system requirements, download URLs, and instructions on how to install and update Docker Desktop for Linux. | ||
|
|
||
| > Download Docker Desktop for Linux packages | ||
| > Follow the links below to view the distro-specific installation instructions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks better, thank you
Currently it's easy for users to skip the per-distro installation steps, since direct download links for our packages are presented first. This can lead to unnecessary frustration, since DD will not install if pre-requisite steps are not followed. So instead of presenting package download links in the most prominent spot, point users to per-distro installation instructions. Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@docker.com>
05f2a1d to
d5b6122
Compare
aevesdocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @p1-0tr!
Proposed changes
Currently it's easy for users to skip the per-distro installation steps,
since direct download links for our packages are presented first. This
can lead to unnecessary frustration, since DD will not install if
pre-requisite steps are not followed. So instead of presenting package
download links in the most prominent spot, point users to per-distro
installation instructions.
Related issues (optional)