Skip to content

Conversation

@gabriellavengeo
Copy link
Contributor

Proposed changes

Document permission requirements and privileged helper functionality for Docker Desktop for Windows

Related issues (optional)

@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8227a5f
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62e3e26e96c036000853096b
😎 Deploy Preview https://deploy-preview-15265--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @gabriellavengeo - just a few minor changes needed.
Also wondering if we need to update 'install from the command line' section on the Windows install page with the additional flags?

gabriellavengeo and others added 2 commits July 29, 2022 15:35
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Fix keyword, typo and wording
@gabriellavengeo
Copy link
Contributor Author

@aevesdocker Thanks for the review! I responded to one of the suggestions, fixed the rest. It seems that the --no-windows-containers flag is already included in the installer documentation

@aevesdocker
Copy link
Contributor

It seems that the --no-windows-containers flag is already included in the installer documentation

facepalm

@aevesdocker aevesdocker merged commit d9dfff4 into docker:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants