Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 16, 2022

carry a commit from #14905 to move "multi stage build" page to Build section > Building images.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d775c8a
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63230f4f7ee9ac0008fda2bf
😎 Deploy Preview https://deploy-preview-15392--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jedevc
Copy link
Contributor

jedevc commented Aug 16, 2022

Hm having a section called "guides" in the "manuals" feels confusing.

Since this relates to Dockerfiles, I wonder if we should have a Dockerfile section under Docker Build? This would be a good first page to put there, but I can easily imagine lots of other content ending up there, like our best practices. Not quite sure, what do you think?

@crazy-max
Copy link
Member Author

Since this relates to Dockerfiles, I wonder if we should have a Dockerfile section under Docker Build?

That SGTM but what about our guides in https://github.com/docker/buildx/tree/master/docs/guides? I recall you had some ideas for a folder under Docker Build section for them.

@jedevc
Copy link
Contributor

jedevc commented Aug 16, 2022

but what about our guides in https://github.com/docker/buildx/tree/master/docs/guides? I recall you had some ideas for a folder under Docker Build section for them

Good point 😆 I think they probably belong in the Buildx section directly, or maybe in an Advanced section under that, if we really start to get too many. I'm not quite sure, I think some of those guides, probably need some love and care before we put them on the site, especially some of the older ones, just to bring them into line with the style of the ones we've already got there.

@thaJeztah thaJeztah added the area/build Relates to Dockerfiles or docker build command label Aug 26, 2022
@crazy-max crazy-max marked this pull request as draft September 11, 2022 11:43
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title build: multi-stage builds user guide build: multi-stage builds Sep 15, 2022
@crazy-max crazy-max removed the request for review from dockertopia September 15, 2022 11:41
@crazy-max crazy-max marked this pull request as ready for review September 15, 2022 11:42
@crazy-max
Copy link
Member Author

@jedevc Moved to "Building images" section and rebased. PTAL.

Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit 6bc1e0d into docker:master Sep 16, 2022
@crazy-max crazy-max deleted the build-multi-stage branch September 16, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants