Fix link #15567
Merged
Fix link #15567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dvdksn
approved these changes
Sep 5, 2022
Member
|
Yeah maybe hardcoded link is better atm |
Member
|
I will take a look to have a "better" degraded mode for GitHub users but LGTM in the meantime. |
crazy-max
approved these changes
Sep 5, 2022
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
|
Also a bit out of scope with this PR but in dark mode, icons don't look great: https://docs.docker.com/contribute/overview/
We should have light and dark mode icons I think. Edit: Looks like it's svg so I guess |
Contributor
Author
|
@crazy-max yes, aware the icons need changing. Am working with one of the designers to get this sorted asap and align with the Design system |
Member
|
Awesome thx @aevesdocker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.