-
Notifications
You must be signed in to change notification settings - Fork 8.1k
_includes/cli.md: do not escape flag descriptions #16093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dvdksn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
Looks like we have to re-generate the YAMLdocs for some other pages from the CLI repository;
|
|
@thaJeztah Oh indeed good catch |
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
d41684b to
efbed96
Compare
|
@thaJeztah @dvdksn PTAL. Should be good to go now. |
|
Changes LGTM, but I now realise (and may have commented on the CLI side) that |
Yes I think we should do smth, left a comment in #16416 (comment) about it. |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! LGTM (thought I did); feel free to merge if we want to get this one in 👍



revert changes #12083
--sshflag with buildx is now properly escaped upstream but with #12083 it now also escapes inline code: https://docs.docker.com/engine/reference/commandline/buildx_build/Signed-off-by: CrazyMax crazy-max@users.noreply.github.com