Skip to content

Conversation

@crazy-max
Copy link
Member

revert changes #12083

--ssh flag with buildx is now properly escaped upstream but with #12083 it now also escapes inline code: https://docs.docker.com/engine/reference/commandline/buildx_build/

image

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max crazy-max requested review from dvdksn and thaJeztah November 5, 2022 08:30
@netlify
Copy link

netlify bot commented Nov 5, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit efbed96
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63dc63ca26806a00086acbac
😎 Deploy Preview https://deploy-preview-16093--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

dvdksn
dvdksn previously approved these changes Nov 5, 2022
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crazy-max
Copy link
Member Author

@thaJeztah Oh indeed good catch

@docker-robott
Copy link
Collaborator

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

@thaJeztah @dvdksn PTAL. Should be good to go now.

@thaJeztah
Copy link
Member

Changes LGTM, but I now realise (and may have commented on the CLI side) that docker build no longer documents any BuildKit options (as we removed those, not hidden them). We need to find a solution to that, otherwise people may think you can only use those options with docker buildx build, and the goal was to make docker build now provide all the options that buildkit provides

@crazy-max
Copy link
Member Author

but I now realise (and may have commented on the CLI side) that docker build no longer documents any BuildKit options (as we removed those, not hidden them). We need to find a solution to that, otherwise people may think you can only use those options with docker buildx build, and the goal was to make docker build now provide all the options that buildkit provides

Yes I think we should do smth, left a comment in #16416 (comment) about it.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! LGTM (thought I did); feel free to merge if we want to get this one in 👍

@crazy-max crazy-max merged commit d96fd81 into docker:main Feb 3, 2023
@crazy-max crazy-max deleted the fix-cli-desc branch February 3, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants