docs: clarify provenance attestation defaults#16764
Merged
Merged
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sozercan
changed the title
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
force-pushed
the
docs-clarify-prov
branch
from
fb9717a to
0ab1468
Compare
dvdksn
reviewed
Feb 24, 2023
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
previously approved these changes
Feb 25, 2023
Member
|
Before merging we should wait for next Buildx 0.10.4 release to avoid confusion. |
Member
|
Hum now that we have a new page for env vars with build, I wonder if we should just add a link to it: https://docs.docker.com/build/building/env-vars/#buildx_no_default_attestations @dvdksn WDYT? |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Contributor
Author
|
@crazy-max @dvdksn updated to link to env vars page, lmk if this works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Clarify provenance defaults
BUILDX_NO_DEFAULT_ATTESTATIONSis not cherry picked yet. docker/buildx#1612Related issues (optional)