desktop: refresh containerd examples #17106
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@thaJeztah @rumpl ptal |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
👍 on removing some of that content (agreed that it's not very useful).
Left some comments / thoughts on what to show on some of the output
dvdksn
force-pushed
the
desktop/refresh-c8d
branch
from
d787709 to
cec4f0c
Compare
Signed-off-by: David Karlsson <david.karlsson@docker.com>
dvdksn
force-pushed
the
desktop/refresh-c8d
branch
from
cec4f0c to
7a1773a
Compare
Signed-off-by: David Karlsson <david.karlsson@docker.com>
dvdksn
force-pushed
the
desktop/refresh-c8d
branch
from
c72d36a to
43de7a9
Compare
|
|
||
| Docker Engine already uses containerd for container lifecycle management, which | ||
| includes creating, starting, and stopping containers. This page describes the | ||
| next step of containerd integration for Docker Engine: the image store. |
There was a problem hiding this comment.
Maybe we can remove the whole "image store" wording and say : image management?
There was a problem hiding this comment.
I think it's better to keep the term "image store" for now, since it also appears in the Docker Desktop settings
| $ docker ps | ||
| CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES | ||
| 93b4d60dfd08 nginx "/docker-entrypoint.…" 3 seconds ago Up 3 seconds 0.0.0.0:8080->80/tcp stoic_mccarthy | ||
| $ docker buildx create --bootstrap |
There was a problem hiding this comment.
Wondering now if we need to show the docker buildx create step at all; would the error-message that's shown above be enough to illustrate what doesn't work without the integration enabled?
There was a problem hiding this comment.
I was thinking to keep it, for those who might be familiar with multi-platform builds using the docker-container driver, to illustrate the limitation with --load
There was a problem hiding this comment.
Ah, gotcha. Yeah, was wondering if users would potentially run the example (and it's only there to illustrate "this is no longer needed")
|
We good with this @rumpl @thaJeztah ? |
|
yes, I have a feeling we have more to say in the limitations section. |
4 participants
Signed-off-by: David Karlsson david.karlsson@docker.com
Proposed changes
This refreshes the containerd examples.
This removes some
docker infoanddocker runexamples, which IMO don't add a lot of useful information.I also rewrote the section no multi-platform builds in an attempt to improve it.
Related issues (optional)
This update was actually triggered by the fact that we should remove the
Registry:field fromdocker info.See: docker/cli#4204