Skip to content

Conversation

@thaJeztah
Copy link
Member

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label Jun 9, 2023
@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 8004050
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6482e59595028b00080e8662
😎 Deploy Preview https://deploy-preview-17511--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

The following commands are equivalent and redirect here:
{% for alias in aliases %}
{%- assign fname = alias | remove_first: "docker " | replace: " ", "_" -%}
- [{{ alias }}](/engine/reference/commandline/{{ fname }}/)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I constructed the URLs for each alias here, but this won't work because we don't have redirects for all aliases.

Some options;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this list does not filter out the "current" page from the list; perhaps that's what we want, or perhaps we want to exclude the "current alias" here (not sure what's best)

I should add here tha

  • (if I did it right everywhere), the first "alias" in the list is considered the "canonical", and ultimately should be the page we redirect them all to, but content would still have to be moved (and we need to review if all those are indeed what we consider the "canonical")
  • "build" is still a tricky one; docker image build is probably the canonical one, but docker buildx build can in some cases provide additional options / ever-so-slightly different behavior, so may not be an "exact" alias.
  • ^^ documentation is also still spread between docker build and docker buildx build

@dvdksn dvdksn self-requested a review June 9, 2023 08:57
@docker-robot
Copy link

docker-robot bot commented Sep 7, 2023

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

@docker-robot
Copy link

docker-robot bot commented Dec 6, 2023

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon lifecycle/stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant