Skip to content

Reorder installation names#19444

Merged
aevesdocker merged 1 commit intodocker:mainfrom
doringeman:rhel
Mar 22, 2024
Merged

Reorder installation names#19444
aevesdocker merged 1 commit intodocker:mainfrom
doringeman:rhel

Conversation

@doringeman
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added area/install Relates to installing a product area/desktop Issue affects a desktop edition of Docker. E.g docker for mac labels Feb 19, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 19, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit d273bf6
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/65df292e48bc6d00087bb76b
😎 Deploy Preview https://deploy-preview-19444--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice, thanks @doringeman. Just some minor quibbles

Comment thread data/toc.yaml Outdated
Comment thread content/desktop/install/rhel.md Outdated
Comment thread content/desktop/install/rhel.md
Comment thread content/desktop/install/rhel.md Outdated
Comment thread content/desktop/install/rhel.md Outdated
Comment thread content/desktop/install/rhel.md Outdated
aevesdocker
aevesdocker previously approved these changes Feb 20, 2024
Copy link
Copy Markdown
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐

Comment thread content/engine/install/rhel.md Outdated
Comment on lines +95 to +96

Install the `yum-utils` package (which provides the `yum-config-manager`
utility) and set up the repository.

```console
$ sudo yum install -y yum-utils
$ sudo yum-config-manager --add-repo {{% param "download-url-base" %}}/docker-ce.repo
$ sudo dnf config-manager --add-repo {{% param "download-url-base" %}}/docker-ce.repo
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page states that installation is supported on RHEL 7,8, and 9. I think RHEL 7 uses yum, and yum is aliased to dnf in RHEL 8 and 9 for backward compatibility. So would this change break RHEL 7 and is that a concern? @neersighted

Although RHEL 8 and RHEL 9 are based on DNF, they are compatible with YUM used in RHEL 7.

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html-single/managing_software_with_the_dnf_tool/index

Red Hat Enterprise Linux 7 will reach end of maintenance on June 30, 2024, but it is not reaching End of Life.

https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux/rhel-7-end-of-maintenance

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looking forward to RHEL and CentOS 7 reaching EOL, but still a couple of months out. Changing to dnf very likely would break users installing.

Also, I don't think we have packages already for RHEL on architectures other than s390x. I know @neersighted was looking into that, but they're not there yet (?)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHEL 7 is not supported on x86_64 and aarch64, but RHEL 8 and 9 are. These are both distributions that include DNF.

@aevesdocker aevesdocker modified the milestone: 4.28 Feb 22, 2024
Copy link
Copy Markdown
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for RHEL on Docker Desktop, let's inline the steps to set up the repository for x86/arm in the DD installation guide rather than link out to the s390x guide for docker-ce, to avoid any confusion and/or compatibility concerns

Comment thread content/desktop/install/rhel.md Outdated
Comment thread content/desktop/install/rhel.md Outdated
Comment thread content/desktop/install/rhel.md Outdated
Comment thread content/desktop/install/rhel.md Outdated
Copy link
Copy Markdown
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but should this be called out as an EAP or is it generally available for DD?

@aevesdocker
Copy link
Copy Markdown
Contributor

Merging now. In a follow up PR I'll add the EAP callout and remove the toc entry as per Bruno's request

@aevesdocker aevesdocker merged commit bfa5ef2 into docker:main Mar 22, 2024
@aevesdocker aevesdocker mentioned this pull request Mar 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/install Relates to installing a product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants