ci: fix validate upstream workflow #19467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
commented
Feb 21, 2024
Contributor
Author
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
cc @crazy-max didn't we have a dummy repo somewhere where we could dry-run this? Or should we do it on a buildx fork/branch?
| const yamlSrcNoExt = yamlSrcPath.replace(".yaml", ""); | ||
| const hasSubCommands = (await (await glob.create(yamlSrcNoExt)).glob()).length > 1; |
Contributor
Author
There was a problem hiding this comment.
This checks if there are more than one data files with the same base name, indicating that the current data file has subcommands.
Comment on lines
+62
to
+63
| if (hasSubCommands) { | ||
| placeholderPath = placeholderPath.replace('.md', '/_index.md'); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
If this has subcommands, the stub filename should be content/reference/cli/docker/cmd/_index.md.
Member
Feel free to do it from a fork and open PR on buildx repo for testing |
Moving the CLI reference files caused the upstream validation workflow to break. This changes the logic in how placeholder files are created in the validation workflow, to match the new filesystem structure for markdown stubs. Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
ci-fix-upstream-validate-workflow
branch
from
d7f0f0e to
9451374
Compare
crazy-max
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com
Description
Moving the CLI reference files caused the upstream validation workflow
to break.
This changes the logic in how placeholder files are created in the
validation workflow, to match the new filesystem structure for markdown
stubs.
Related issues
docker/buildx#2269
Verified with docker/buildx#2273