Skip to content

build: git remote authentication secrets#23460

Merged
dvdksn merged 8 commits into
docker:mainfrom
jcgruenhage:git-auth-secrets
Apr 24, 2026
Merged

build: git remote authentication secrets#23460
dvdksn merged 8 commits into
docker:mainfrom
jcgruenhage:git-auth-secrets

Conversation

@jcgruenhage
Copy link
Copy Markdown
Contributor

@jcgruenhage jcgruenhage commented Sep 25, 2025

Description

I fixed the documentation, because it was wrong. See the issues and buildkit PR for details.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 25, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit a16068d
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69eb2aee134fbd000850e2cd
😎 Deploy Preview https://deploy-preview-23460--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the area/build Relates to Dockerfiles or docker build command label Sep 25, 2025
@sarahsanders-docker sarahsanders-docker added the status/review Pull requests that are ready for review label Sep 26, 2025
@aevesdocker aevesdocker removed the status/review Pull requests that are ready for review label Oct 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the PR. We'd like to make our product docs better, but haven't been able to review all the suggestions. As our docs change often and quickly diverge, we do not have the bandwidth to review and rebase old PRs.

If the updates are still relevant, please add a comment and review our contribution guidelines to rebase your PR against the latest version of the docs. This helps our maintainers focus on active contributions. If there's no activity, this PR will be closed in 30 days.

To remove the stale label: Comment /lifecycle active
To freeze (requires write access): Comment /lifecycle frozen

Copy link
Copy Markdown
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we can soften the language on "GitHub-specific" vs "any provider", otherwise LGTM

Comment thread content/manuals/build/building/secrets.md Outdated
Comment thread content/manuals/build/building/secrets.md Outdated
Comment thread content/manuals/build/building/secrets.md Outdated
Comment thread content/manuals/build/building/secrets.md Outdated
Comment thread content/manuals/build/building/secrets.md Outdated
Comment thread content/manuals/build/building/secrets.md Outdated
Comment thread content/manuals/build/building/secrets.md Outdated
jcgruenhage and others added 7 commits April 24, 2026 10:32
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn
Copy link
Copy Markdown
Contributor

dvdksn commented Apr 24, 2026

/review

@jcgruenhage
Copy link
Copy Markdown
Contributor Author

Thanks for the review @dvdksn!

@dvdksn dvdksn merged commit 891c1d7 into docker:main Apr 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants