Skip to content

Correcting PR URL in 17.06.2-ee-4 notes #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaofnfernandes merged 1 commit into from
Nov 7, 2017
Merged

Correcting PR URL in 17.06.2-ee-4 notes #5236

joaofnfernandes merged 1 commit into from
Nov 7, 2017

Conversation

@ericsmalling
Copy link
Contributor

@ericsmalling ericsmalling commented Nov 7, 2017 •
edited by thaJeztah
Loading

Proposed changes

Linked URL of PR was incorrect - fixed it.

fixes #5235

thaJeztah
thaJeztah approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah mentioned this pull request Nov 7, 2017
Closed
@joaofnfernandes
Copy link
Contributor

joaofnfernandes commented Nov 7, 2017

Let's ship it then 🚀
@thaJeztah keep in mind that the source of truth for these release notes is docker/docker-ee (private repo). I don't think in this case we need to send a PR upstream, but are you pinged for reviews on that repo / does it make sense for you to be pinged in the future?

@joaofnfernandes joaofnfernandes merged commit 5d7d669 into docker:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

17.06.2-ee-4 note Serialize IP allocation docker/libnetwork#1788 links to wrong repo

3 participants

@ericsmalling @joaofnfernandes @thaJeztah