Add a note regarding retrieving log messages when tty is enabled#5321
Merged
Conversation
thaJeztah
previously requested changes
Nov 17, 2017
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! Left some suggestions
| $ sudo journalctl -o json CONTAINER_NAME=webserver | ||
| ``` | ||
|
|
||
| ### Note regarding Tty enabled containers |
Member
There was a problem hiding this comment.
By starting with "Note" this becomes a ... wel, "note"; perhaps change the title to make it a regular example; something like;
### View logs for a container with a TTY enabled |
|
||
| ### Note regarding Tty enabled containers | ||
|
|
||
| When Tty is enabled on a container you may see `[10B blob data]` in the output |
Member
There was a problem hiding this comment.
Perhaps: "If a TTY is enabled"
When running a container with tty enabled and setting the journald logging driver, you may see "blob data" instead of the real log message. That's because tty appends "\r" to the end of the log line, which isn't stripped by jorunald unless you specify the "--all" flag. Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
mdlinville
approved these changes
Nov 17, 2017
Contributor
Author
|
Thank you! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When running a container with tty enabled and setting the journald
logging driver, you may see "blob data" instead of the real log
message.
That's because tty appends "\r" to the end of the log line,
which isn't stripped by jorunald unless you specify the "--all" flag.
Related issues (optional)
related to moby/moby#35416 and moby/moby#22450