Skip to content

Add swarm task state REMOVE#6206

Merged
gbarr01 merged 4 commits into
docker:masterfrom
gbarr01:swarm_task_states
Apr 11, 2018
Merged

Add swarm task state REMOVE#6206
gbarr01 merged 4 commits into
docker:masterfrom
gbarr01:swarm_task_states

Conversation

@gbarr01
Copy link
Copy Markdown
Contributor

@gbarr01 gbarr01 commented Mar 12, 2018

@gbarr01 gbarr01 requested a review from thaJeztah March 12, 2018 22:36
@gbarr01
Copy link
Copy Markdown
Contributor Author

gbarr01 commented Mar 19, 2018

@thaJeztah , this is the only real change. Good?

REMOVE | The task is ready for removal after shutdown succeeds. It will not be kept around in task history.

Also, should it be last in the table?

@gbarr01 gbarr01 changed the title [WIP] Add swarm task state REMOVE Add swarm task state REMOVE Apr 11, 2018
@gbarr01 gbarr01 merged commit 542032c into docker:master Apr 11, 2018
are initialized in the `NEW` state. The task progresses forward through a
number of states, and its state doesn't go backward. For example, a task never
goes from `COMPLETE` to `RUNNING`.
Tasks advance through a number of states until they complete or fail. Tasks are initialized in the `NEW` state. The task progresses forward through a number of states, and its state doesn't go backward. For example, a task never goes from `COMPLETE` to `RUNNING`.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these paragraphs un-wrapped? Perhaps a setting in your editor?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was probably me ... I'll fix it. Just curious, how does that affect you?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows more granular commenting when reviewing, and makes the text more readable when viewing in source view. Also see (e.g.) https://github.com/carwin/markdown-styleguide (I think there's some other places that describe common MarkDown standards

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants