Add swarm task state REMOVE#6206
Merged
Merged
Conversation
added 2 commits
March 19, 2018 14:13
Contributor
Author
|
@thaJeztah , this is the only real change. Good?
Also, should it be last in the table? |
thaJeztah
reviewed
Apr 12, 2018
| are initialized in the `NEW` state. The task progresses forward through a | ||
| number of states, and its state doesn't go backward. For example, a task never | ||
| goes from `COMPLETE` to `RUNNING`. | ||
| Tasks advance through a number of states until they complete or fail. Tasks are initialized in the `NEW` state. The task progresses forward through a number of states, and its state doesn't go backward. For example, a task never goes from `COMPLETE` to `RUNNING`. |
Member
There was a problem hiding this comment.
Why were these paragraphs un-wrapped? Perhaps a setting in your editor?
Contributor
Author
There was a problem hiding this comment.
It was probably me ... I'll fix it. Just curious, how does that affect you?
Member
There was a problem hiding this comment.
It allows more granular commenting when reviewing, and makes the text more readable when viewing in source view. Also see (e.g.) https://github.com/carwin/markdown-styleguide (I think there's some other places that describe common MarkDown standards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6203
See: moby/swarmkit#2485