Skip to content

Remove "docker engine" commands #9984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 2 commits into from
Jan 22, 2020
Merged

Remove "docker engine" commands #9984

thaJeztah merged 2 commits into from
Jan 22, 2020

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 6, 2019

relates to docker/cli#2213

These subcommands were created to allow upgrading a Docker Community engine to Docker Enterprise, but never really took off. With the migration of the docker "enterprise" products to Mirantis, we should remove these subcommands as releases may no longer be done in sync in future.

@thaJeztah thaJeztah added area/engine Issue affects Docker engine/daemon area/release-notes Release Notes labels Dec 6, 2019
@thaJeztah thaJeztah mentioned this pull request Dec 6, 2019
Closed
8 tasks
@GordonTheTurtle
Copy link

GordonTheTurtle commented Dec 6, 2019 •
edited
Loading

Deploy preview for docsdocker ready!

Built with commit ebc3b50

https://deploy-preview-9984--docsdocker.netlify.com

@justincormack
Copy link
Contributor

justincormack commented Jan 22, 2020

LGTM

@thaJeztah
Remove "docker engine" subcommands
f24e2f1 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Update yaml files to remove "engine" subcommands
ebc3b50 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the remove_engine_commands branch from 564316d to ebc3b50 Compare January 22, 2020 14:49
@thaJeztah thaJeztah changed the title [WIP] Remove "docker engine" commands Remove "docker engine" commands Jan 22, 2020
@thaJeztah thaJeztah marked this pull request as ready for review January 22, 2020 14:49
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 22, 2020

rebased, and moved out of draft: the commands have not yet been removed from the docker CLI, but we won't be supporting this workflow, so we should remove the documentation.

@thaJeztah thaJeztah merged commit 7fb9bc0 into docker:master Jan 22, 2020
@thaJeztah thaJeztah deleted the remove_engine_commands branch January 22, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@usha-mandya usha-mandya usha-mandya approved these changes

Assignees

No one assigned

Labels

area/engine Issue affects Docker engine/daemon area/release-notes Release Notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @GordonTheTurtle @justincormack @usha-mandya