Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 7, 2019

relates to docker/cli#2215 "[epic] remove experimental "docker (stack) deploy" using "dab" files"

Deploying stacks using the "Docker Application Bundle" (.dab) file
format was introduced as an experimental feature in Docker 1.13 /
17.03, but superseded by support for Docker Compose files in the CLI.

With no development being done on this feature, and no active use of the file
format, support for the DAB file format and the top-level docker deploy command
(hidden by default in 19.03), will be removed from the CLI, in favour of
docker stack deploy using compose files.

This patch removes documentation for the docker-compose bundle subcommand,
which was used to convert compose files into DAB files (and given the above,
will no longer be needed).

Proposed changes

Unreleased project version (optional)

Related issues (optional)

@thaJeztah thaJeztah added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Dec 7, 2019
@GordonTheTurtle
Copy link

GordonTheTurtle commented Dec 7, 2019

Deploy preview for docsdocker ready!

Built with commit d4ead1b

https://deploy-preview-9987--docsdocker.netlify.com

@thaJeztah thaJeztah changed the title [WIP] Remove "bundle" subcommand and support for DAB files Remove "bundle" subcommand and support for DAB files Jan 22, 2020
@thaJeztah thaJeztah marked this pull request as ready for review January 22, 2020 14:31
Deploying stacks using the "Docker Application Bundle" (`.dab`) file
format was introduced as an experimental feature in Docker 1.13 /
17.03, but superseded by support for Docker Compose files in the CLI.

With no development being done on this feature, and no active use of the file
format, support for the DAB file format and the top-level `docker deploy` command
(hidden by default in 19.03), will be removed from the CLI, in favour of
`docker stack deploy` using compose files.

This patch removes documentation for the `docker-compose bundle` subcommand,
which was used to convert compose files into DAB files (and given the above,
will no longer be needed).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Moved this out of "WIP": The current version of docker-compose (v1.25.2) has the bundle subcommand removed; https://github.com/docker/compose/commits/v1.25.2/compose

Given that this command was experimental in the docker cli, I think we could go ahead and merge this (even though the current docker cli still has the experimental top-level docker deploy command

@chris-crone @nebuk89 SGTY?

@justincormack
Copy link
Contributor

LGTM

@thaJeztah thaJeztah merged commit 49eb8fa into docker:master Jan 22, 2020
@thaJeztah thaJeztah deleted the remove_dab_bundle branch January 22, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compose Relates to docker-compose.yml spec or docker-compose binary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants