Fix channel sink#30
Open
Adirio wants to merge 3 commits into
Open
Conversation
stevvooe
reviewed
Oct 1, 2018
| case <-ch.closed: | ||
| return ErrSinkClosed | ||
| default: | ||
| ch.C <- event |
Contributor
There was a problem hiding this comment.
This will block forever is ch.closed is closed after the check.
Author
There was a problem hiding this comment.
The new commit should fix this. Nested selects are not as pretty as flat ones but as Go chooses randomly if two of the select cases can be performed at entering, this is the only way to force a check on the channel before while still keeping the non-blocking functionality.
Avoid blocking on Channel.Write if Channel.Close is called after the check is done
Member
|
@stevvooe ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
It uses the
defaultcase lower priority to check first if theChannelsink is closed.