This repository was archived by the owner on Oct 6, 2025. It is now read-only.
feat: allow stopping the LLM with ctrl-c without exiting #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
When a chat request is ongoing, allow pressing Ctrl+C to interrupt just that single chat request, without exiting the app, and print a message indicating that Ctrl+C can be used again to exit the app. To accomplish this, update all desktop/ functions to take a context.Context, and then implement a cancellable chat function that uses signal.NotifyContext() to handle the interrupt signal. Intercept only os.Interrupt, which Ctrl+C is mapped to and is available on all the supposed OSes, including Windows. Signed-off-by: Alberto Garcia Hierro <damaso.hierro@docker.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a chat request is ongoing, allow pressing Ctrl+C to interrupt
just that single chat request, without exiting the app, and print
a message indicating that Ctrl+C can be used again to exit the app.
To accomplish this, update all desktop/ functions to take a context.Context,
and then implement a cancellable chat function that uses signal.NotifyContext()
to handle the interrupt signal.
Intercept only os.Interrupt, which Ctrl+C is mapped to and is available
on all the supposed OSes, including Windows.
Signed-off-by: Alberto Garcia Hierro damaso.hierro@docker.com