Skip to content

fix deb package version#123

Merged
crazy-max merged 2 commits into
docker:mainfrom
crazy-max:fix-deb-ver
May 25, 2023
Merged

fix deb package version#123
crazy-max merged 2 commits into
docker:mainfrom
crazy-max:fix-deb-ver

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented Apr 9, 2023

./pkg/buildx/bin
└── [4.0K]  debian
    └── [4.0K]  bookworm
        └── [4.0K]  amd64
            ├── [4.7K]  docker-buildx-plugin_0.0.0~20230330153147~33388d6-0~debian.12~bookworm_amd64.buildinfo
            ├── [1.4K]  docker-buildx-plugin_0.0.0~20230330153147~33388d6-0~debian.12~bookworm_amd64.changes
            ├── [ 26M]  docker-buildx-plugin_0.0.0~20230330153147~33388d6-0~debian.12~bookworm_amd64.deb
            ├── [ 51K]  provenance.json
            └── [8.8M]  sbom.json
./pkg/buildx/bin
└── [4.0K]  ubuntu
    └── [4.0K]  lunar
        └── [4.0K]  amd64
            ├── [5.4K]  docker-buildx-plugin_0.0.0~20230405150350~1e149bb-0~ubuntu.23.04~lunar_amd64.buildinfo
            ├── [1.4K]  docker-buildx-plugin_0.0.0~20230405150350~1e149bb-0~ubuntu.23.04~lunar_amd64.changes
            ├── [ 26M]  docker-buildx-plugin_0.0.0~20230405150350~1e149bb-0~ubuntu.23.04~lunar_amd64.deb
            ├── [ 51K]  provenance.json
            └── [5.5M]  sbom.json
./pkg/containerd/bin
└── [4.0K]  debian
    └── [4.0K]  bookworm
        └── [4.0K]  amd64
            ├── [2.8M]  containerd.io-dbgsym_0.0.0~20230330082121~812111e-1~debian.12~bookworm_amd64.deb
            ├── [5.2K]  containerd.io_0.0.0~20230330082121~812111e-1~debian.12~bookworm_amd64.buildinfo
            ├── [1.8K]  containerd.io_0.0.0~20230330082121~812111e-1~debian.12~bookworm_amd64.changes
            ├── [ 25M]  containerd.io_0.0.0~20230330082121~812111e-1~debian.12~bookworm_amd64.deb
            ├── [ 70K]  provenance.json
            └── [9.0M]  sbom.json
./pkg/containerd/bin
└── [4.0K]  ubuntu
    └── [4.0K]  bionic
        └── [4.0K]  amd64
            ├── [2.8M]  containerd.io-dbgsym_0.0.0~20230330082121~812111e-1~ubuntu.18.04~bionic_amd64.ddeb
            ├── [5.7K]  containerd.io_0.0.0~20230330082121~812111e-1~ubuntu.18.04~bionic_amd64.buildinfo
            ├── [1.8K]  containerd.io_0.0.0~20230330082121~812111e-1~ubuntu.18.04~bionic_amd64.changes
            ├── [ 25M]  containerd.io_0.0.0~20230330082121~812111e-1~ubuntu.18.04~bionic_amd64.deb
            ├── [ 70K]  provenance.json
            └── [5.0M]  sbom.json
./pkg/docker-engine/bin
└── [4.0K]  debian
    └── [4.0K]  bookworm
        └── [4.0K]  amd64
            ├── [8.6M]  docker-ce-rootless-extras_0.0.0~20230330133036~efc7a2a-3~debian.12~bookworm_amd64.deb
            ├── [6.4K]  docker-ce_0.0.0~20230330133036~efc7a2a-3~debian.12~bookworm_amd64.buildinfo
            ├── [1.8K]  docker-ce_0.0.0~20230330133036~efc7a2a-3~debian.12~bookworm_amd64.changes
            ├── [ 22M]  docker-ce_0.0.0~20230330133036~efc7a2a-3~debian.12~bookworm_amd64.deb
            ├── [ 61K]  provenance.json
            └── [ 11M]  sbom.json
./pkg/docker-engine/bin
└── [4.0K]  ubuntu
    └── [4.0K]  jammy
        └── [4.0K]  amd64
            ├── [8.6M]  docker-ce-rootless-extras_0.0.0~20230330133036~efc7a2a-3~ubuntu.22.04~jammy_amd64.deb
            ├── [7.8K]  docker-ce_0.0.0~20230330133036~efc7a2a-3~ubuntu.22.04~jammy_amd64.buildinfo
            ├── [1.8K]  docker-ce_0.0.0~20230330133036~efc7a2a-3~ubuntu.22.04~jammy_amd64.changes
            ├── [ 22M]  docker-ce_0.0.0~20230330133036~efc7a2a-3~ubuntu.22.04~jammy_amd64.deb
            ├── [ 61K]  provenance.json
            └── [7.0M]  sbom.json

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Comment thread pkg/compose/verify.Dockerfile Outdated
COPY --from=xx / /
ARG PKG_RELEASE
ARG PKG_DISTRO
ARG PKG_ID
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if PKG_DISTRO_ID (to indicate these are related to the distro) would be clearer (I guess same for PKG_DISTRO_SUITE)

It's a bit longer of course 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, should be good.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from thaJeztah April 9, 2023 16:00
@crazy-max crazy-max marked this pull request as ready for review April 9, 2023 16:00
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Copy Markdown

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max merged commit a40b98a into docker:main May 25, 2023
@crazy-max crazy-max deleted the fix-deb-ver branch May 25, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants