Skip to content

Conversation

@crazy-max
Copy link
Member

No description provided.

crazy-max added 3 commits May 26, 2023 01:51
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review May 26, 2023 00:03
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we only bumped credential-helpers to 1.20.3?

@crazy-max
Copy link
Member Author

Is there a reason we only bumped credential-helpers to 1.20.3?

Yeah this is still 1.20.3 on def branch: https://github.com/docker/docker-credential-helpers/blob/da93839996460f358368e183cbd8da06feae3fec/Dockerfile#L3

@thaJeztah
Copy link
Member

@crazy-max I added @neersighted as collaborator on this repo ("maintainer" access).

We should probably look at creating a "packagers" or "release" team that we can use to give access to the (etoomany) repositories we have related to that now. (perhaps we need separate teams for the internal (private) and external repos though)

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 👍

@thaJeztah
Copy link
Member

Yeah this is still 1.20.3 on def branch: https://github.com/docker/docker-credential-helpers/blob/da93839996460f358368e183cbd8da06feae3fec/Dockerfile#L3

I think we should be good updating it to 1.20.4 in this repo though (other repo should be updated as well; let me open a PR for that)

@thaJeztah
Copy link
Member

@neersighted
Copy link
Member

I'm not sure we need separate teams, as to join a team you have to be part of the org (I think); thus any external (non-Docker Inc.) collaborators need to be non-team members. Maybe I'm wrong on that, through.

Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on cred-helper update to 1.20.4

crazy-max added 3 commits May 27, 2023 20:00
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max merged commit 6ace256 into docker:main May 28, 2023
@crazy-max crazy-max deleted the bump-go branch May 28, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants