Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 5, 2023

@crazy-max crazy-max force-pushed the rockylinux branch 6 times, most recently from bcfb685 to e4c5162 Compare August 5, 2023 07:44
@crazy-max crazy-max force-pushed the rockylinux branch 2 times, most recently from 66d109d to d95cbe2 Compare August 5, 2023 09:23
@crazy-max crazy-max changed the title rpm: add rockylinux 8 and 9 rpm: add rockylinux and almalinux Aug 5, 2023
@crazy-max
Copy link
Member Author

Added alma linux as well

@crazy-max
Copy link
Member Author

crazy-max commented Oct 21, 2023

@thaJeztah @neersighted I see rocky and alma pkgs are being built for containerd now: docker/containerd-packaging@967611b. Are we good merging this one?

@crazy-max crazy-max force-pushed the rockylinux branch 2 times, most recently from 3a2e57a to 453c591 Compare October 28, 2023 03:24
@AkihiroSuda
Copy link

What's the current status?

EOL of CentOS Stream 8 is approaching (2024-05-31), so it would be nice to merge this soon

@crazy-max
Copy link
Member Author

What's the current status?

EOL of CentOS Stream 8 is approaching (2024-05-31), so it would be nice to merge this soon

We can merge this one for testing but release packaging happening on download.docker.com is still linked to https://github.com/docker/docker-ce-packaging

@crazy-max crazy-max marked this pull request as ready for review February 8, 2024 15:36
@scaleoutsean
Copy link

Do you know how frequently they decide to update those links, @crazy-max?

Meanwhile, many Rocky users have no choice but to use CentOS packages.
https://docs.rockylinux.org/gemstones/containers/docker/

@AkihiroSuda
Copy link

Any chance to merge this?
cc @thaJeztah

@crazy-max crazy-max force-pushed the rockylinux branch 2 times, most recently from 8f0a245 to 100c1ec Compare June 14, 2025 19:03
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Outdated
# Same as ones in docker-bake.hcl
DISTROS_DEB ?= debian11 debian12 debian13 ubuntu2204 ubuntu2404 raspbian11 raspbian12
DISTROS_RPM ?= centos9 fedora41 fedora42 oraclelinux8 oraclelinux9
DISTROS_RPM ?= centos9 fedora41 fedora42 oraclelinux8 oraclelinux9 rockylinux8 rockylinux9 almalinux8 almalinux9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit; do we want to keep this list sorted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed will do that

docker-bake.hcl Outdated
Comment on lines 30 to 34
"oraclelinux9"
"oraclelinux9",
"rockylinux8",
"rockylinux9",
"almalinux8",
"almalinux9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here; perhaps keep it sorted?

Makefile Outdated
# Same as ones in docker-bake.hcl
DISTROS_DEB ?= debian11 debian12 debian13 ubuntu2204 ubuntu2404 raspbian11 raspbian12
DISTROS_RPM ?= centos9 fedora41 fedora42 oraclelinux8 oraclelinux9
DISTROS_RPM ?= centos9 fedora41 fedora42 oraclelinux8 oraclelinux9 rockylinux8 rockylinux9 almalinux8 almalinux9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we support EL 10?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we can for almalinux:10 but seems rockylinux:10 is not yet available on Hub.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look at this as follow-up

Copy link
Collaborator

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

RockyLinux isn't happy, looks like;

#32 [linux/amd64 builder-rpm 5/7] RUN --mount=type=bind,from=scripts,source=rpm-builddep.sh,target=/usr/local/bin/rpm-builddep   rpm-builddep $(xx-info rhel-arch) /root/rpmbuild/SPECS
#32 12.16 Package bash-5.1.8-9.el9.x86_64 is already installed.
#32 12.17 Package bash-5.1.8-9.el9.x86_64 is already installed.
#32 12.17 Package ca-certificates-2024.2.69_v8.0.303-91.4.el9_4.noarch is already installed.
#32 12.17 Package libarchive-3.5.3-4.el9.0.1.x86_64 is already installed.
#32 12.17 Package pkgconf-pkg-config-1.7.3-10.el9.x86_64 is already installed.
#32 12.17 Package tar-2:1.34-7.el9.x86_64 is already installed.
#32 12.19 Error: 
#32 12.19  Problem: conflicting requests
#32 12.19   - nothing provides systemd-pam = 252-51.el9_6.1 needed by systemd-devel-252-51.el9_6.1.x86_64 from appstream
#32 12.19   - nothing provides systemd-libs(x86-64) = 252-51.el9_6.1 needed by systemd-devel-252-51.el9_6.1.x86_64 from appstream
#32 12.19   - nothing provides systemd-pam = 252-51.el9_6.1 needed by systemd-devel-252-51.el9_6.1.i686 from appstream
#32 12.19   - nothing provides systemd-libs(x86-32) = 252-51.el9_6.1 needed by systemd-devel-252-51.el9_6.1.i686 from appstream
#32 12.19 (try to add '--skip-broken' to skip uninstallable packages)
#32 ERROR: process "/bin/sh -c rpm-builddep $(xx-info rhel-arch) /root/rpmbuild/SPECS" did not complete successfully: exit code: 1

@crazy-max
Copy link
Member Author

RockyLinux isn't happy, looks like;

Yes repo looks flaky 😰

@crazy-max crazy-max merged commit 609451e into docker:main Jun 27, 2025
444 of 447 checks passed
@crazy-max crazy-max deleted the rockylinux branch June 27, 2025 12:36
@AkihiroSuda
Copy link

The packages are still not pushed to https://download.docker.com/linux/ ?

@vvoland
Copy link
Collaborator

vvoland commented Sep 19, 2025

Not yet, but will be in the nearest future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants