-
Notifications
You must be signed in to change notification settings - Fork 29
rpm: add rockylinux and almalinux #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcfb685 to
e4c5162
Compare
66d109d to
d95cbe2
Compare
|
Added alma linux as well |
|
@thaJeztah @neersighted I see rocky and alma pkgs are being built for containerd now: docker/containerd-packaging@967611b. Are we good merging this one? |
3a2e57a to
453c591
Compare
|
What's the current status? EOL of CentOS Stream 8 is approaching (2024-05-31), so it would be nice to merge this soon |
We can merge this one for testing but release packaging happening on |
|
Do you know how frequently they decide to update those links, @crazy-max? Meanwhile, many Rocky users have no choice but to use CentOS packages. |
|
Any chance to merge this? |
8f0a245 to
100c1ec
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Makefile
Outdated
| # Same as ones in docker-bake.hcl | ||
| DISTROS_DEB ?= debian11 debian12 debian13 ubuntu2204 ubuntu2404 raspbian11 raspbian12 | ||
| DISTROS_RPM ?= centos9 fedora41 fedora42 oraclelinux8 oraclelinux9 | ||
| DISTROS_RPM ?= centos9 fedora41 fedora42 oraclelinux8 oraclelinux9 rockylinux8 rockylinux9 almalinux8 almalinux9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit; do we want to keep this list sorted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes indeed will do that
docker-bake.hcl
Outdated
| "oraclelinux9" | ||
| "oraclelinux9", | ||
| "rockylinux8", | ||
| "rockylinux9", | ||
| "almalinux8", | ||
| "almalinux9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here; perhaps keep it sorted?
Makefile
Outdated
| # Same as ones in docker-bake.hcl | ||
| DISTROS_DEB ?= debian11 debian12 debian13 ubuntu2204 ubuntu2404 raspbian11 raspbian12 | ||
| DISTROS_RPM ?= centos9 fedora41 fedora42 oraclelinux8 oraclelinux9 | ||
| DISTROS_RPM ?= centos9 fedora41 fedora42 oraclelinux8 oraclelinux9 rockylinux8 rockylinux9 almalinux8 almalinux9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we support EL 10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can for almalinux:10 but seems rockylinux:10 is not yet available on Hub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look at this as follow-up
vvoland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
RockyLinux isn't happy, looks like; |
Yes repo looks flaky 😰 |
|
The packages are still not pushed to https://download.docker.com/linux/ ? |
|
Not yet, but will be in the nearest future! |
fyi @AkihiroSuda @thaJeztah @neersighted