-
Notifications
You must be signed in to change notification settings - Fork 29
distro: add ubuntu 23.10 #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f4f48b5 to
712bef0
Compare
|
In the logs for the failed centos7 build https://github.com/docker/packaging/actions/runs/6487035111/job/17678315850#step:8:35 shows
but https://github.com/docker/packaging/actions/runs/6487035111/job/17678315850#step:8:774 reports this failure: |
This has been fixed with #168 Can you rebase? Thanks |
@crazy-max I fixed the conflict. Is that enough? I'm not sure what you want me to rebase against, sorry. |
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase? Thanks
@crazy-max I fixed the conflict. Is that enough? I'm not sure what you want me to rebase against, sorry.
Can you squash please? Otherwise LGTM thanks!
dcdfaf7 to
3490d41
Compare
@crazy-max Not a git expert, so I force pushed a single commit. I hope that's OK. |
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually you need to add ubuntu2310 here as well:
Line 18 in f7d0d6a
| PKG_DEB_RELEASES ?= debian10 debian11 debian12 ubuntu2004 ubuntu2204 ubuntu2304 raspbian10 raspbian11 raspbian12 |
Signed-off-by: Ross Smith II <ross@smithii.com>
3490d41 to
966a7fb
Compare
@crazy-max Fixed. Sorry I missed that. I mimic'd the 23.04 PR. |
relates to docker/docker-ce-packaging#949
relates to docker/containerd-packaging@68ea373 - docker/containerd-packaging#328
Ubuntu 23.10 is planned to be released on October 12, 2023, but final betas are available now.