deb, rpm: slight refactor and cleanup#229
Merged
crazy-max merged 3 commits intodocker:mainfrom Jun 27, 2025
Merged
Conversation
crazy-max
force-pushed
the
deb-rpm-cleanups
branch
from
16715a4 to
1e83df0
Compare
Member
|
Wondering if we want to preserve some of the history / context from the individual commits in the other PR; have you tried if patches from that PR would apply (if the path is rewritten)? docker/docker-ce-packaging#1154 |
Member
Author
Might be possible, I can try |
The "make dynbinary" target calls ./scripts/build/binary with the right options set, and does not use docker to build (so can be run as part of our deb/rpm build scripts. Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
… -p" The "-D" option creates parent directories if missing; we can use it in most places, except for one where we're using wildcards, as installing multiple files requires the target directory to exist. "install -p" unlikely makes a big difference, as some files may have timestampsbased on checkout date or being generated, but it doesn't hurt doing either. Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
The dh_bash-completion debhelper provides an easy way to install the shell-completion scripts for Bash. Unfortunately there is no stable equivalent yet for the other shells (zsh, fish, powershell), which resulted in two out of three shells requiring manual install. Given that the installation path for Bash is [well-documented][1], we can align Bash with the other shells to make this less confusing. This patch makes that change, and adds a code-comment to outline the reasoning (and possible future options) for future readers. [1]: https://github.com/scop/bash-completion/blob/79fd051907328c8c26372691f68d627c1f0e3916/README.md Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
deb-rpm-cleanups
branch
from
1e83df0 to
af62dc9
Compare
Member
Author
|
Was not able to align history so kept comments instead if that's fine with you |
vvoland
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up: