-
Notifications
You must be signed in to change notification settings - Fork 29
add model package #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add model package #230
Conversation
2ed488d to
e136da8
Compare
747b0c8 to
8b324f9
Compare
|
Interesting; how could we get a 403 for these? Expired token or something, or was there an incident on Docker Hub? |
Yes seems to be some flakiness from Docker Hub 🤔 |
|
ISTR we had a fix for this, or was this just another whoopsie of hub? (or perhaps the version of docker / BuildKit used)? I kicked CI again 😅 |
Yeah seems to be some cloudflare issue :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like upstream doesn't have a Dockerfile, other than for generating the docs; should we add one there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think they should have one. At least they should pin Go version, atm it always takes latest, see docker/model-cli#62 (comment)
1227602 to
683b648
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
follow-up: