-
Notifications
You must be signed in to change notification settings - Fork 29
pkg(docker-cli,docker-engine): add arm/v5 platform #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Resulting binaries look OK on my system: 👀 $ cat /proc/cpuinfo
processor : 0
model name : Feroceon 88FR131 rev 1 (v5l)
BogoMIPS : 400.00
Features : swp half thumb fastmult edsp
CPU implementer : 0x56
CPU architecture: 5TE
CPU variant : 0x2
CPU part : 0x131
CPU revision : 1
Hardware : Marvell Kirkwood (Flattened Device Tree)
Revision : 0000
Serial : 0000000000000000
$ ./dockerd --version
Docker version v0.0.0-20230115001426-98c1140, build 98c1140c4490699d65a2fcd1009570fc0e412550
$ ./docker-init --version
tini version 0.19.0 - git.de40ad0
$ ./docker-proxy --version
docker-proxy (commit 98c1140c4490699d65a2fcd1009570fc0e412550) version v0.0.0-20230115001426-98c1140 |
ad533cf to
e089f95
Compare
| FROM build-base-static AS builder-static-nosdk | ||
| ARG DEBIAN_FRONTEND | ||
| RUN apt-get install -y --no-install-recommends dpkg-dev clang lld llvm make pkg-config | ||
| ARG PKG_NAME | ||
| ARG DOCKER_CLI_REF | ||
| ARG NIGHTLY_BUILD | ||
| WORKDIR /build | ||
| ARG TARGETPLATFORM | ||
| RUN xx-apt-get install -y gcc libc6-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it makes a difference for caching, but some questions;
- move the PKG_NAME and some of the other ones later?
- do the
apt-getandxx-apt-getsteps have to be separate? (would it make sense to combine them otherwise?) - does
xx-apt...useTARGETPLATFORM? If not, that one could be moved until after that step as well
| FROM build-base-static AS builder-static-nosdk | |
| ARG DEBIAN_FRONTEND | |
| RUN apt-get install -y --no-install-recommends dpkg-dev clang lld llvm make pkg-config | |
| ARG PKG_NAME | |
| ARG DOCKER_CLI_REF | |
| ARG NIGHTLY_BUILD | |
| WORKDIR /build | |
| ARG TARGETPLATFORM | |
| RUN xx-apt-get install -y gcc libc6-dev | |
| FROM build-base-static AS builder-static-nosdk | |
| WORKDIR /build | |
| ARG DEBIAN_FRONTEND | |
| RUN xx-apt-get install -y --no-install-recommends \ | |
| clang \ | |
| dpkg-dev \ | |
| gcc \ | |
| libc6-dev \ | |
| lld \ | |
| llvm \ | |
| make \ | |
| pkg-config | |
| ARG DOCKER_CLI_REF | |
| ARG NIGHTLY_BUILD | |
| ARG PKG_NAME | |
| ARG TARGETPLATFORM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- move the PKG_NAME and some of the other ones later?
Yes good point, could be moved after xx-apt
- do the
apt-getandxx-apt-getsteps have to be separate? (would it make sense to combine them otherwise?)
Yes they have because xx-apt-get is using TARGET_PLATFORM.
- does
xx-apt...useTARGETPLATFORM? If not, that one could be moved until after that step as well
Yes every xx-* command needs TARGETPLATFORM.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Avoids issue with dockercore/golang-cross:xx-sdk-extras that doesn't have a dummy linux/arm/v5 platform Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
No description provided.