Remove the comment about the extension being installed with Microsoft's#105
Merged
Remove the comment about the extension being installed with Microsoft's#105
Conversation
The Docker DX extension is no longer bundled with Microsoft's Docker extension so we should remove the note in the readme. Signed-off-by: Remy Suen <remy.suen@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The readme still mentions that we are being installed with Microsoft's extension when that is no longer the case as of microsoft/vscode-docker#4562.
Proposed Solution
Removed the line about the optional dependency from the readme.
Proof of Work
See rendered readme here.