Skip to content

compose and K8s file cleanup #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikesir87 merged 1 commit into from
Dec 17, 2022
Merged

compose and K8s file cleanup #273

mikesir87 merged 1 commit into from
Dec 17, 2022

Conversation

@BretFisher
Copy link
Collaborator

@BretFisher BretFisher commented Dec 17, 2022 •
edited
Loading

Removing old files we don't tend to maintain:

  • Windows Container builds of this solution
  • Duplicate K8s, compose, and stack files

Other enhancements:

  • Readme was also updated
  • Postgres images updated to v15

@BretFisher BretFisher requested a review from mikesir87 December 17, 2022 02:48
@BretFisher BretFisher added the dependencies Pull requests that update a dependency file label Dec 17, 2022
@BretFisher BretFisher self-assigned this Dec 17, 2022
mikesir87
mikesir87 approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@mikesir87 mikesir87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! LGTM!

@mikesir87 mikesir87 merged commit 226edf0 into main Dec 17, 2022
@mikesir87 mikesir87 deleted the compose-cleanup branch December 17, 2022 02:50
@Privat33r-dev Privat33r-dev mentioned this pull request May 2, 2024
Open
GhenaCadin pushed a commit to Pokfinner/example-voting-app that referenced this pull request Jan 4, 2025
@BretFisher
compose and K8s file cleanup (dockersamples#273)
94c49c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikesir87 mikesir87 mikesir87 approved these changes

Assignees

@BretFisher BretFisher

Labels

cleanup dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BretFisher @mikesir87