Skip to content

Conversation

@trycontrolmymind
Copy link
Contributor

Before this PR

I has 2 docs versions in same folder
index.public.html and index.dev.html versions.
To get them by docsify-cli I need to create empty index.html

After this PR

I've create a flag --index-name or -i to specify the default index file.
Now I'm able to manually serve index.public.html and index.dev.html

@QingWei-Li QingWei-Li merged commit dc8e993 into docsifyjs:master Feb 18, 2019
install:
- npm install
- npm install -g gulp
- npm install natives@1.1.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

@@ -10,8 +10,8 @@
"integrity": "sha512-3Sp6WZZ/lXl+nTDoGpGWHEpTnnC6X5fnkolYZR6nwIfzbxxvA8utPWe1gCt7i0m9uVGsSz2IS8K8mJ7HmlduMg==",
"dev": true,
"requires": {
"jsonparse": "^1.2.0",
"through": ">=2.2.7 <3"
"jsonparse": "1.3.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove package-lock.json and package.json changes

@timaschew
Copy link
Member

What a pitty. I didn't realize that after I've commented on lines I need to start a reiew explicitly.
Anyway. This MR introduced a malicious module: dominictarr/event-stream#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants