Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

🗑️ 🎨 Clean ignored properties #33

Closed
pimpin wants to merge 2 commits into from
Closed

🗑️ 🎨 Clean ignored properties #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d02bfd
rm deprecated code
pimpin Dec 12, 2023
a13cd08
format code
pimpin Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions lib/couchbase-orm/utilities/ignored_properties.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
module CouchbaseOrm
module IgnoredProperties
def ignored_properties=(properties)
@ignored_properties = properties.map(&:to_s)
end
module IgnoredProperties
def ignored_properties=(properties)
@ignored_properties = properties.map(&:to_s)
end

def ignored_properties(*args)
if args.any?
CouchbaseOrm.logger.warn('Passing aruments to `.ignored_properties` is deprecated. PLease use `.ignored_properties=` intead.')
return send :ignored_properties=, args
end
@ignored_properties ||= []
end
def ignored_properties(*_args)
Copy link
Member

@JulienBURNET-FAUCHE JulienBURNET-FAUCHE Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we juste remove the args parameter ?

@ignored_properties ||= []
end
end
end