[BC break] Remove namespace aliases from the configuration #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Dec 16, 2025
GromNaN
commented
Dec 16, 2025
| */ | ||
| public function __construct(Definition|Reference $driver, array $namespaces, array $managerParameters, string|false $enabledParameter = false, array $aliasMap = []) | ||
| public function __construct(Definition|Reference $driver, array $namespaces, array $managerParameters, string|false $enabledParameter = false) | ||
| { |
Member
Author
There was a problem hiding this comment.
Removing a parameter is not a breaking change.
IonBazan
approved these changes
Dec 17, 2025
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Dec 19, 2025
…asMap` (GromNaN) This PR was merged into the 8.1 branch. Discussion ---------- [DoctrineBridge] Deprecate `RegisterMappingsPass::$aliasMap` | Q | A | ------------- | --- | Branch? | 8.1 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | - | License | MIT Namespace aliases have been deprecated from `doctrine/persistence` [2.3.0](https://github.com/doctrine/persistence/releases/tag/2.3.0) doctrine/persistence#204, and removed from [3.0.0](doctrine/persistence@7422aab#diff-65217b628918b27724f64d13ef152e91e8d5223c594e564f8583fb2045cb779f). - DoctrineBundle accepts this parameter, but the method `Configuration::addEntityNamespace` has been removed in `dotrine/orm` 3.0.0, which make it broken. Removing in doctrine/DoctrineMongoDBBundle#971 - DoctrineMongoDBBundle accepts them but the namespace alias support is no longer supported. Removing in doctrine/DoctrineBundle#2169 - DoctrinePHPCRBundle removed usage of this parameter in doctrine/DoctrinePHPCRBundle@dc82197 Projects using the child classes of `RegisterMappingPass` never set an `$aliasMap`. - [`FOSUserBundle`](https://github.com/FriendsOfSymfony/FOSUserBundle/blob/607a7fb975bc0c39bc2aa7e4ab8c52aded74d63c/src/FOSUserBundle.php#L46-L52) Removing this parameters is a breaking change but could be already done in 8.1 as it is unsupported or broken for all the Doctrine bundles. Commits ------- 4ecc888 [DoctrineBridge] Deprecate RegisterMappingsPass::$aliasMap, not supported by ORM and MongoDB ODM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace aliases are not supported by
doctrine/persistencesince 3.0.0, which is the minimum version required by this bundle.This means the aliases injected into the configuration are not used. And we deprecated the methods that inject them in doctrine/mongodb-odm#2957
I propose introducing a breaking change, since short aliases no longer work anyway.
Related to symfony/symfony#62792
Fix doctrine/mongodb-odm#2957 (comment)