Document, test and expose the DoctrineMongoDBMappingsPass
#972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the @internal annotation from DoctrineMongoDBMappingsPass to properly expose it as a public API, since it's designed for third-party bundles to register document mappings. The change includes comprehensive test coverage and documentation.
- Removed
@internalannotation fromDoctrineMongoDBMappingsPassclass - Added comprehensive test suite covering all four mapping driver types (XML, PHP, Attribute, StaticPHP)
- Created documentation explaining how bundles should use the compiler pass
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/DependencyInjection/Compiler/DoctrineMongoDBMappingsPass.php | Removed @internal annotation to expose class as public API |
| tests/DependencyInjection/Compiler/DoctrineMongoDBMappingsPassTest.php | Added test coverage for all four mapping driver factory methods |
| docs/index.rst | Added reference to new bundles documentation page |
| docs/cookbook/bundles.rst | Created comprehensive guide for third-party bundle developers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GromNaN
force-pushed
the
mappings-pass
branch
from
c45bcde to
a19c810
Compare
alcaeus
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking
DoctrineMongoDBMappingsPassas@internalis incorrect. This class is made to be used by 3rd party bundles to register mapping for their own document classes.Example of usage: