Bug "Undefined offset: 0" introduced in 1.12

[ACTINEO-Ben]

There seems to be a new bug introduced with the latest 1.12 version.
Since I did not use it directly but used l5-swagger, which is using swagger-php which uses doctrine/annotations, I'm not exactly sure how to reproduce this easily.

What I can tell is that in line 1447 of the DocParser.php index "0" of the variable $positionalArguments is directly referenced, but the first set index in that variable at this point for me was "2".
This is what I saw when I var_exported the content right before it failed:

So this should be an easy fix I think, but I'm not deep enough in that library to be able to both create a test and fix this issue myself.

For now I reverted back to 1.11.2 and everything is working again.

[kevinpapst]

The commit f1f293a introduced that regression/bug. It is happening for me as well.

This code here directly access index 0:

annotations/lib/Doctrine/Common/Annotations/DocParser.php

Lines 1446 to 1450 in ebec9b1

	if (count($positionalArguments) === 1) {
	$value = $positionalArguments[0];
	} else {
	$value = array_values($positionalArguments);
	}

I have seen at least index 1 and 2, while 0 was not set.
For me it happens in on PHP 7.4, a Symfony project and it triggers in FosRestBundle controller with Swagger annotations.

Using this code instead fixed it for me:

 if (count($positionalArguments) === 1) { 
     $value = array_pop($positionalArguments); 
 } else { 
     $value = array_values($positionalArguments); 
 } 

@Vincz can you remember if there was a reason accessing index 0?

[Vincz]

@kevinpapst My mistake. I wrongly assumed that positional arguments after named one was not valid.
The problem should be fixed in #406

[kevinpapst]

Thanks for the late night fix!