Enhancement: Use stages on Travis#174
Merged
lcobucci merged 1 commit intodoctrine:masterfrom Feb 3, 2018
Merged
Conversation
localheinz
force-pushed
the
feature/stages
branch
from
ce05140 to
07273d7
Compare
Contributor
|
Can you please use same setup/layout as we use in other Doctrine repos where Stages are already introduced? I don't really like having different setups for different projects... Thanks. |
localheinz
force-pushed
the
feature/stages
branch
2 times, most recently
from
2ae536c to
948d1b9
Compare
Contributor
Author
|
Sure, using |
localheinz
force-pushed
the
feature/stages
branch
from
948d1b9 to
e79f584
Compare
This was referenced Feb 3, 2018
localheinz
force-pushed
the
feature/stages
branch
from
e79f584 to
30491f9
Compare
Contributor
The same could be said about the proposed change here - i.e. I've never seen & or* in the config. I'm not opposed to improvements, but let's keep it consistent if possible and propose changes afterwards. |
localheinz
force-pushed
the
feature/stages
branch
from
30491f9 to
703dd73
Compare
Contributor
Author
|
I can recommend http://blog.daemonl.com/2016/02/yaml.html, then! 🤓 |
localheinz
force-pushed
the
feature/stages
branch
from
703dd73 to
149627a
Compare
2 tasks
lcobucci
approved these changes
Feb 3, 2018
| include: | ||
| - stage: Lint | ||
| before_script: | ||
| - travis_retry composer require --dev --prefer-dist --prefer-stable phpstan/phpstan:^0.7 |
Member
There was a problem hiding this comment.
We need to upgrade phpstan to ^0.9!
Member
|
@localheinz 🚢 thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Blocks #177.
💁♂️ For reference, see https://docs.travis-ci.com/user/build-stages/.