Drop SimpleAnnotationReader

[Majkl578]

closes #87

[Ocramius]

Question: do we want to enforce importing annotations (as in "stop looking for same-namespace annotations") to remove the ambiguity in resolved symbols? That was the biggest problem with this reader: too much implicit resolution.

[Majkl578]

stop looking for same-namespace annotations

This may be a bit problematic since same-namespace uses are considered superfluous by IDEs and CS.

Honestly I have little experience with this reader in real world since it was always too magical. What I hate most on this reader is the fact that you can register multiple namespaces in which to look for annotations. Then comes the WTF - colliding names are ignored, first one is used:

annotations/lib/Doctrine/Common/Annotations/DocParser.php

Lines 699 to 706 in b4fde48

	if ($this->namespaces) {
	foreach ($this->namespaces as $namespace) {
	if ($this->classExists($namespace.'\\'.$name)) {
	$name = $namespace.'\\'.$name;
	$found = true;
	break;
	}
	}

Do we have any statistics for SimpleAnnotationReader usage? Would this even be reason to keep it?
Imho imported annotations should stay, same-namespace lookup should stay too (for the reason above), but namespaces to search in should be dropped.

[Ocramius]

same-namespace uses are considered superfluous by IDEs and CS.

Agreed. I'm mostly talking from experience in dealing with bug reports, where people type in something like @Collection and have a Collection in their current namespace.

This is the scope of my original question.

On the other side, this is consistent with PHP's import and name resolution semantics, so I may just be going nowhere with it.

you can register multiple namespaces

No more: burn it with napalm.

Do we have any statistics for SimpleAnnotationReader usage? Would this even be reason to keep it?

We made the mistake of basing the ORM simplistic setup on it (including many of the docs). The replacement of the annotations can be automated (or at least reported), so we don't need to concern ourselves with it. Let's just kill it.

Given a SimpleAnnotationReader, we can build a tool that reports replacements to be performed.

[Ocramius]

I think there's nothing else to be done here, and this is good to go from my perspective 👍

[Majkl578]

Good thing is that it's already gone from ORM dev-master. 🎉

Following PHP resolution rules is the way to go, the least confusing one.
Once we have 2.0 ready for alpha/beta, we can run some survey to see whether missing SimpleAnnotationReader behavior is a blocker for someone or not.

Given a SimpleAnnotationReader, we can build a tool that reports replacements to be performed.

Sounds good to me. 👍

[Majkl578]

Alright, let's move on.