Eliminate AnnotationRegistry, rely on autoloading only#205
Merged
Ocramius merged 2 commits intodoctrine:masterfrom May 9, 2018
Merged
Eliminate AnnotationRegistry, rely on autoloading only#205Ocramius merged 2 commits intodoctrine:masterfrom
Ocramius merged 2 commits intodoctrine:masterfrom
Conversation
This was referenced May 9, 2018
Ocramius
suggested changes
May 9, 2018
|
|
||
| // final check, does this class exist? | ||
| return $this->classExists[$fqcn] = AnnotationRegistry::loadAnnotationClass($fqcn); | ||
| return $this->classExists[$fqcn] = class_exists($fqcn); |
Member
There was a problem hiding this comment.
The entire private method can be dropped
Member
There was a problem hiding this comment.
If not: what is our reason for caching a failure?
Contributor
Author
There was a problem hiding this comment.
This whole thing will be gone soon once Hoa parser is in place so I'd ignore that for now.
Member
There was a problem hiding this comment.
Alright, let's not touch it for now 👌
There was a problem hiding this comment.
This whole thing will be gone soon once Hoa parser is in place
What's that?
Majkl578
force-pushed
the
drop-AnnotationRegistry
branch
from
5172aef to
90a4524
Compare
Majkl578
force-pushed
the
drop-AnnotationRegistry
branch
from
90a4524 to
467c5c3
Compare
Ocramius
approved these changes
May 9, 2018
Member
|
Thanks @kingcrunch and @Majkl578! |
Kutuzovska
added a commit
to Kutuzovska/yii-cycle
that referenced
this pull request
Jun 22, 2023
In doctrine v2+ "AnnotationRegistry::registerLoader" - Feature has been removed. doctrine/annotations#205
Kutuzovska
added a commit
to Kutuzovska/yii-cycle
that referenced
this pull request
Jun 22, 2023
In doctrine v2+ "AnnotationRegistry::registerLoader" - Feature has been removed. doctrine/annotations#205
IssamRaouf
added a commit
to IssamRaouf/symfony-docs
that referenced
this pull request
Jul 24, 2023
[Dropping AnnotationRegistry completely, relying on native autoloading instead](doctrine/annotations#205)
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jul 28, 2023
…stry::registerLoader (IssamRaouf) This PR was merged into the 5.4 branch. Discussion ---------- [micro_kernel] Fix deleted feature AnnotationRegistry::registerLoader [Dropping AnnotationRegistry completely, relying on native autoloading instead](doctrine/annotations#205) v2.0.0 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 9168b9d [micro_kernel] Fix deleted method AnnotationRegistry::registerLoader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping AnnotationRegistry completely, relying on native autoloadin instead.
Incorporates #61 as a separate commit to keep attributions of @kingcrunch.