Skip to content

Add Scrutinizer CI#206

Merged
jwage merged 1 commit intodoctrine:masterfrom
Majkl578:scrutinizer
May 9, 2018
Merged

Add Scrutinizer CI#206
jwage merged 1 commit intodoctrine:masterfrom
Majkl578:scrutinizer

Conversation

@Majkl578
Copy link
Copy Markdown
Contributor

@Majkl578 Majkl578 commented May 9, 2018

Basically copied from Migrations and CS condition removed (not used in this repo, yet) and added coverage.

@Majkl578 Majkl578 added the CI label May 9, 2018
@Majkl578 Majkl578 added this to the v2.0.0 milestone May 9, 2018
@Majkl578 Majkl578 added the WIP label May 9, 2018
@Majkl578 Majkl578 force-pushed the scrutinizer branch 2 times, most recently from 7abfec2 to 05e3917 Compare May 9, 2018 19:23
@Majkl578
Copy link
Copy Markdown
Contributor Author

Majkl578 commented May 9, 2018

Didn't find any way to disable phpcs run (and Patches) so let's just ignore it until we add CS later.

@jwage jwage merged commit 49c2911 into doctrine:master May 9, 2018
@Majkl578 Majkl578 deleted the scrutinizer branch May 9, 2018 20:37
Comment thread .travis.yml
- |
if [ "x$COVERAGE" == "xyes" ] && [[ ! $(php -m | grep -si xdebug) ]]; then
echo "xdebug is required for coverage"
exit 1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using exit in a command put in the .travis.yml will exit the whole build script, which will break the Travis output (as reporting for this command will not be done, as well as following tasks).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I hear about it. 🤔 What would you suggest as replacement here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there used to be a warning in the Travis doc about it in the past, but I cannot find it anymore (they reorganized their doc in the meantime).

I thinkk you can use travis_terminate 1 for that (which is a command which will exit with 1 as exit code, and so become a failure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants