Change Annotation::value typehint to mixed#209
Merged
Conversation
alcaeus
approved these changes
May 22, 2018
Ocramius
suggested changes
May 22, 2018
| /** | ||
| * Value property. Common among all derived classes. | ||
| * | ||
| * @var string |
Member
There was a problem hiding this comment.
Should be annotated as mixed instead of being skipped
Member
There was a problem hiding this comment.
Isn't mixed implied when it's not further specified?
Member
Author
There was a problem hiding this comment.
This was also my assumption. Unless we're explicitly saying mixed just to show we care enough :D
Member
There was a problem hiding this comment.
Isn't
mixedimplied when it's not further specified?
"implied" is something we no longer really allow. Even our coding standards prevent us from skipping parameters/return types. Possibly a missing CS rule, @carusogabriel?
Contributor
There was a problem hiding this comment.
@Ocramius I’ll add some tests in our CS repo and discovered what should be fixed to avoid it :)
`string` is wrong as it can also be `null` or an `array`. Merging this (and tagging a new bugfix release) would help me with doctrine/mongodb-odm#1803 :)
malarzm
changed the title
Member
Author
|
@Ocramius |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stringis wrong as it can also benullor anarray. Merging this (and tagging a new bugfix release) would help me with doctrine/mongodb-odm#1803 :)