Skip to content

Update AnnotationReader's metadata parser to use list of known ignored annotation #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcobucci merged 1 commit into from
Jan 28, 2019
Merged

Update AnnotationReader's metadata parser to use list of known ignored annotation #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/Doctrine/Annotations/AnnotationReader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ public function __construct(DocParser $parser = null)

$this->preParser->setImports(self::$globalImports);
$this->preParser->setIgnoreNotImportedAnnotations(true);
$this->preParser->setIgnoredAnnotationNames(self::$globalIgnoredNames);

$this->phpParser = new PhpParser;
}
Expand Down
22 changes: 22 additions & 0 deletions tests/Doctrine/Tests/Annotations/AbstractReaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,28 @@ public function testInvalidAnnotationButIgnored()
self::assertEmpty($reader->getPropertyAnnotations($class->getProperty('foo')));
}

public function testGloballyIgnoredAnnotationNotIgnored() : void
{
$reader = $this->getReader();
$class = new \ReflectionClass(Fixtures\ClassDDC1660::class);

$testLoader = static function (string $className) : bool {
if ($className === 'since') {
throw new \InvalidArgumentException('Globally ignored annotation names should never be passed to an autoloader.');
}

return false;
};

spl_autoload_register($testLoader, true, true);

try {
self::assertEmpty($reader->getClassAnnotations($class));
} finally {
spl_autoload_unregister($testLoader);
}
}

public function testAnnotationEnumeratorException()
{
$reader = $this->getReader();
Expand Down