Update AnnotationReader's metadata parser to use list of known ignored annotation#240
Closed
sanmai wants to merge 10 commits intodoctrine:1.12.xfrom
Closed
Update AnnotationReader's metadata parser to use list of known ignored annotation#240sanmai wants to merge 10 commits intodoctrine:1.12.xfrom
sanmai wants to merge 10 commits intodoctrine:1.12.xfrom
Conversation
package name seems wrong
Update index.rst
…d annotation A parser used to collect parsing metadata basically ignores a known list of globally ignored annotation names, goes through loops checking annotations that do not need any checking. Let's fix that by communicating the list during initialization.
sanmai
commented
Jan 30, 2019
| \Doctrine\Common\Annotations\AnnotationRegistry::registerLoader($testLoader); | ||
|
|
||
| try { | ||
| self::assertNotNull($reader->getClassAnnotations($class)); |
Contributor
Author
There was a problem hiding this comment.
Unlike #235, in this case getClassAnnotations() returns non-empty array. I guess testInvalidAnnotationButIgnored is broken, but fixing it proper should be done in a different PR.
sanmai
commented
Jan 30, 2019
| $reader = $this->getReader(); | ||
| $class = new \ReflectionClass(Fixtures\ClassDDC1660::class); | ||
|
|
||
| $active = true; |
Contributor
Author
There was a problem hiding this comment.
Another way to disable this autoloader would be using a ReflectionProperty like in AnnotationRegistryTest, not sure if it is any better.
Member
|
Let's close the PR. I think it's obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A parser used to collect parsing metadata basically ignores a known list of globally ignored annotation names, goes through loops checking annotations that do not need any checking. Let's fix that by communicating the list during initialization.
This is a backported fix from #235.