Extract implicitly ignored annotation names to separate class#242
Merged
Ocramius merged 1 commit intodoctrine:masterfrom Feb 26, 2019
Merged
Conversation
Contributor
Majkl578
commented
Feb 19, 2019
Majkl578
commented
- To improve readability and maintainability of this list.
- Categorized, each category ordered alphabetically.
- Will be further used in Annotations 2.0.
greg0ire
approved these changes
Feb 19, 2019
| 'Annotation' => true, | ||
| 'Attribute' => true, | ||
| 'Attributes' => true, | ||
| /* Can we enable this? 'Enum' => true, */ |
Member
There was a problem hiding this comment.
What about this question? This is from 5 years ago. I think it can be removed.
Contributor
Author
There was a problem hiding this comment.
Didn't really want to do side-effects during just extracting the annotations. Also in 2.0 these reserved annotations will likely not be needed anymore.
SenseException
approved these changes
Feb 20, 2019
Ocramius
reviewed
Feb 26, 2019
| ]; | ||
|
|
||
| public const LIST = self::Reserved | ||
| + self::WidelyUsedNonStandard |
Member
There was a problem hiding this comment.
Ooooooh, I like this style of merging stuff in constants!
Ocramius
approved these changes
Feb 26, 2019
Member
|
This can go to |
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.