Upgrade Doctrine CS, use only for new files#253
Upgrade Doctrine CS, use only for new files#253Majkl578 wants to merge 1 commit intodoctrine:masterfrom
Conversation
| <file>lib/</file> | ||
| <file>tests/</file> | ||
|
|
||
| <exclude-pattern>lib/Doctrine/Annotations/Annotation/*</exclude-pattern> |
There was a problem hiding this comment.
Lots and lots of excludes: is this worth doing in first place, if half the lib isn't covered at all?
There was a problem hiding this comment.
It's for the new files we add, e.g. #247, new parser etc.
|
@alcaeus Already described the situation in OP:
|
|
After discussion in Slack, we've decided to hold back introducing doctrine/coding-standard until the initial refactoring is done: the current coding standard should not be applied to code that will not survive refactoring, but at the same time we also don't want to apply the coding standard to a small subset of files. Instead, maintainers and containers are encouraged to make sure their code is formatted in compliance with doctrine/coding-standard. However, code reviews should refrain from enforcing doctrine/coding-standard until it is officially adopted in the repository and checked automatically. |
6.0.x-dev because I am going to use the new syntax for generics and intersections which only works in 6.0-dev.
Not applying to any code from 1.x era to avoid headaches during rebase conflicts. We will do it later for files that survive refactoring.