Skip to content

Make phpdoc comments accurate #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Majkl578 merged 1 commit into from
Mar 29, 2019
Merged

Make phpdoc comments accurate #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/Doctrine/Annotations/DocParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,6 @@ private function collectAnnotationMetadata($name)

/**
* Collects parsing metadata for a given attribute.
*
* @param array $metadata
* @param Attribute $attribute
*/
private function collectAttributeTypeMetadata(
PropertyMetadataBuilder $metadata,
Expand Down
3 changes: 0 additions & 3 deletions lib/Doctrine/Annotations/Metadata/AnnotationMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ final class AnnotationMetadata
/** @var PropertyMetadata|null */
private $defaultProperty;

/**
* @param PropertyMetadata[] $properties
*/
public function __construct(
string $name,
AnnotationTarget $target,
Expand Down
4 changes: 2 additions & 2 deletions lib/Doctrine/Annotations/Metadata/Builder/PropertyMetadataBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ final class PropertyMetadataBuilder
/** @var bool */
private $default = false;

/** @var array<int|float|string|bool>|null */
/** @var array<string, array<int|float|string|bool>|string>|null */
private $enum;

public function __construct(string $name)
Expand Down Expand Up @@ -56,7 +56,7 @@ public function withBeingDefault() : self
}

/**
* @param array<int|float|string|bool>|null $enum
* @param array<string, array<int|float|string|bool>|string> $enum
Comment thread
greg0ire marked this conversation as resolved.
*/
public function withEnum(array $enum) : self
{
Expand Down
6 changes: 3 additions & 3 deletions lib/Doctrine/Annotations/Metadata/PropertyMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ final class PropertyMetadata
/** @var bool */
private $default;

/** @var array<int|float|string|bool>|null */
/** @var array<string, array<int|float|string|bool>|string>|null */
private $enum;

/**
* @param array<string, string> $type
* @param array<int|float|string|bool>|null $enum
* @param array<string, array<int|float|string|bool>|string>|null $enum
*/
public function __construct(
string $name,
Expand Down Expand Up @@ -67,7 +67,7 @@ public function isDefault() : bool
}

/**
* @return array<int|float|string|bool>|null
* @return array<string, array<int|float|string|bool>|string>|null
*/
public function getEnum() : ?array
{
Expand Down