Allow php 8#334
Merged
alcaeus merged 2 commits intodoctrine:1.10.xfrom May 25, 2020
Merged
Conversation
The CI passes, the next logical step would be to get reports from downstream users. This allows to remove the ignore-platform-reqs flag when installing dependencies in the CI. The nightly job is kept in "allow_failures", since we should not create a sense of urgency about this.
Member
|
@greg0ire The second commit brings us from this
To this
I would recommend the following:
We can apply the strategy to all our packages. |
alcaeus
approved these changes
May 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI passes, the next logical step would be to get reports from
downstream users. This allows to remove the ignore-platform-reqs flag
when installing dependencies in the CI.
The nightly job is kept in "allow_failures", since we should not create
a sense of urgency about this.
I'm targeting 1.10.x so that this restriction can be lifted ASAP