Add some MySQL platform data in Tables #2415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bburnichon
force-pushed
the
feature/mysql-table-metadata
branch
2 times, most recently
from
29499f2 to
aa370ee
Compare
morozov
requested changes
Nov 9, 2018
tests/Doctrine/Tests/DBAL/Functional/Schema/MySqlSchemaManagerTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Tests/DBAL/Functional/Schema/MySqlSchemaManagerTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Tests/DBAL/Functional/Schema/MySqlSchemaManagerTest.php
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I finally replaced global request by a call for each table. It makes more SQL queries but simplify handling both cases. |
morozov
reviewed
Nov 14, 2018
morozov
reviewed
Nov 14, 2018
bburnichon
commented
Nov 15, 2018
Member
|
@bburnichon, the patch looks good to me. Please squash and I'll merge it. |
bburnichon
force-pushed
the
feature/mysql-table-metadata
branch
from
be67e77 to
a7cffda
Compare
Contributor
Author
|
@morozov squashed rebased done and ready |
morozov
approved these changes
Nov 16, 2018
Member
|
Thank you, @bburnichon! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MySQL specific table metadata.