omitPath new function #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Missing a backtick. And the semicolon is unnecessary. 😄
Contributor
|
@manrueda I think this should probably go into the object.builders module. Then you can use |
jgonggrijp
added
before modules
jgonggrijp
added a commit
to jgonggrijp/underscore-contrib
that referenced
this pull request
Aug 31, 2020
jgonggrijp
added a commit
to jgonggrijp/underscore-contrib
that referenced
this pull request
Aug 31, 2020
…ntcloud#177 Also reimplements the function as suggested by @joshuacc. More tests pass in this way, but still not all. This is somewhat inconsistent; arguably, _.omitWhen, _.pickWhen and _.selectKeys belong in object.builders, too.
jgonggrijp
added a commit
to jgonggrijp/underscore-contrib
that referenced
this pull request
Aug 31, 2020
jgonggrijp
added a commit
to jgonggrijp/underscore-contrib
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was in the need of exclude nested values of an objects, so extend the omit function to work with paths.
It's a heavy function, but does what need to do...