Skip to content

_.toQuery fix #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgonggrijp merged 4 commits into from
Aug 31, 2020
Merged

_.toQuery fix #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61a44f4
Add a test to reproduce #217
jgonggrijp Aug 29, 2020
8eaa5dc
Remove empty query substrings before concatenating (fix #217)
jgonggrijp Aug 29, 2020
f83c293
Test against null and undefined after a comment by @carpben (#217)
jgonggrijp Aug 30, 2020
dc0b553
Filter empty strings from array recursion as well (#217)
jgonggrijp Aug 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/util.strings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ $(document).ready(function() {
var obj = {'foo&bar': 'baz', 'test': 'total success', 'nested': {'works': 'too'}, 'isn\'t': ['that', 'cool?']};
assert.equal(_.toQuery(obj), 'foo%26bar=baz&test=total%20success&nested%5Bworks%5D=too&isn\'t%5B%5D=that&isn\'t%5B%5D=cool%3F', 'can convert a hash to a query string');
assert.equal(_.toQuery(obj), jQuery.param(obj), 'query serialization matchs jQuery.param()');
assert.equal(_.toQuery({a: []}), '', 'empty array params produce the empty string');
assert.equal(_.toQuery({a: [], b: []}), '', 'multiple empty array params do not lead to spurious ampersands');
assert.equal(_.toQuery({a: null, b: undefined}), 'a=null&b=undefined', 'respects null and undefined');
});

QUnit.test('strContains', function(assert) {
Expand Down
8 changes: 4 additions & 4 deletions underscore.util.strings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@
var buildParams = function(prefix, val, top) {
if (_.isUndefined(top)) top = true;
if (_.isArray(val)) {
return _.map(val, function(value, key) {
return _.compact(_.map(val, function(value, key) {
return buildParams(top ? key : prefix + '[]', value, false);
}).join('&');
})).join('&');
} else if (_.isObject(val)) {
return _.map(val, function(value, key) {
return _.compact(_.map(val, function(value, key) {
return buildParams(top ? key : prefix + '[' + key + ']', value, false);
}).join('&');
})).join('&');
} else {
return urlEncode(prefix) + '=' + urlEncode(val);
}
Expand Down