Fixes for building with clang-cl and wine headers. #4402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Eh I was indeed curious why these casts were not missing in the first place, looks like it'll need to be fixed differently... |
Contributor
|
I don't think we include |
Contributor
Author
|
For some reason they end up in the namespace when I build with clang-cl, and it definitely fails to build. But I'll look into it. |
rbernon
force-pushed
the
develop
branch
3 times, most recently
from
f9fc69b to
b365ef3
Compare
MinGW dxgi import lib advertises some D3DKMT functions, which our dxgi doesn't implement, that later will crash when the functions are resolved and we should instead pull them from gdi32.dll.
And provide dummy fallbacks for non-Win32 platforms. This also updates the definitions to better match the Windows SDK headers, making future additions easier.
Setting shared resource runtime private data is normally not possible and is implemented using a Wine-specific D3DKMTEscape code instead.
Setting shared resource runtime private data is normally not possible and is implemented using a Wine-specific D3DKMTEscape code instead.
Reading the shared resource runtime private data should work with native D3D resource handles, although the runtime private data format is still different.
rbernon
force-pushed
the
develop
branch
2 times, most recently
from
002cccf to
98cccf2
Compare
This loads the acquire / release functions lazily as they have only been recently added to Wine GDI32 exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of compilation failures found while experimenting with clang msvc mode.